Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSK Manager v0.9.8 #30

Merged
merged 1 commit into from
Mar 19, 2025
Merged

TSK Manager v0.9.8 #30

merged 1 commit into from
Mar 19, 2025

Conversation

calvinpark
Copy link
Collaborator

@calvinpark calvinpark commented Mar 3, 2025

This is a major overhaul.

  1. Tried to make it less daunting to a newcomer.
    a. Covered only the happy path in the main section.
    b. Non-essential information was moved into the Troubleshooting fold.
    c. Removed the Fingerprinting & SSH sections
  2. Uses the new TSK Manager
  3. Downloaded the build cache so that in-car steps take less than 5 minutes.

I've considered adding the expected time for each section, but they now all take only around 2 minutes.

Now waiting for

  1. openpilot v0.9.8 release commaai/openpilot#34737 to merge so that commaai/devel has the v0.9.8 release.
  2. Update the installer to use the commaai/devel branch.
  3. Rebase tskm-0.9.8 onto commaai/devel
  4. Push tskm-0.9.8 to optskug/openpilot.

@calvinpark calvinpark force-pushed the calvin/tskm-0.9.8 branch 20 times, most recently from 70b88c6 to 84db0f1 Compare March 6, 2025 01:40
@calvinpark
Copy link
Collaborator Author

@nelsonjchen @chrispypatt Still waiting for the official release, but the doc is ready to be reviewed. The Setup Guide is completely new so just read it using the preview. The Forks section changes are better seen through the diff. Thank you

@chrispypatt
Copy link
Contributor

Very nice rewrite of the doc! Nice work. I'm a fan of the troubleshooting expandable sections.

@calvinpark calvinpark force-pushed the calvin/tskm-0.9.8 branch 6 times, most recently from ea3a7e5 to 30de416 Compare March 12, 2025 04:55
@calvinpark calvinpark force-pushed the calvin/tskm-0.9.8 branch 2 times, most recently from db5ceac to 0c36e24 Compare March 18, 2025 03:51
@calvinpark calvinpark changed the title WIP: TSK Manager v0.9.8 TSK Manager v0.9.8 Mar 19, 2025
@calvinpark
Copy link
Collaborator Author

@nelsonjchen Ready to merge in case you want to check it out

@nelsonjchen
Copy link
Collaborator

Looks fine to me. It's git, nothing is lost. That said, I think we had some offers for people to review a bit in Discord but maybe we can just ask them to review the merged product.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

@calvinpark calvinpark merged commit 35a39e9 into main Mar 19, 2025
@calvinpark calvinpark deleted the calvin/tskm-0.9.8 branch March 19, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants