-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSK Manager v0.9.8 #30
Conversation
70b88c6
to
84db0f1
Compare
@nelsonjchen @chrispypatt Still waiting for the official release, but the doc is ready to be reviewed. The Setup Guide is completely new so just read it using the preview. The Forks section changes are better seen through the diff. Thank you |
84db0f1
to
93a36bd
Compare
Very nice rewrite of the doc! Nice work. I'm a fan of the troubleshooting expandable sections. |
ea3a7e5
to
30de416
Compare
db5ceac
to
0c36e24
Compare
0c36e24
to
42a0ca9
Compare
42a0ca9
to
971507d
Compare
@nelsonjchen Ready to merge in case you want to check it out |
Looks fine to me. It's git, nothing is lost. That said, I think we had some offers for people to review a bit in Discord but maybe we can just ask them to review the merged product. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
This is a major overhaul.
a. Covered only the happy path in the main section.
b. Non-essential information was moved into the Troubleshooting fold.
c. Removed the Fingerprinting & SSH sections
I've considered adding the expected time for each section, but they now all take only around 2 minutes.
Now waiting for
commaai/devel
has the v0.9.8 release.commaai/devel
branch.tskm-0.9.8
ontocommaai/devel
tskm-0.9.8
tooptskug/openpilot
.