feat: odp datafile parsing and audience evaluation #303
Conversation
Mat001
left a comment
Mat001
left a comment
There was a problem hiding this comment.
Looks ok to me.
Just ine comment about comment indentaton.
| def qualified_evaluator(condition) | ||
| # Evaluate the given match condition for the given user qaulified segments. | ||
| # Returns boolean true if condition value is in the user's qualified segments, | ||
| # false if the condition value is not in the user's qualified segments, |
There was a problem hiding this comment.
Is this wide indent a ruby commenting style? I don't know, just mentioning :)
Seems a bit weird?
There was a problem hiding this comment.
I just matched the existing style in this file. Looks like the intention was to line up the different return values visually. I have no strong feelings about it either way 🤷
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks good! A couple of small changes suggested.
lib/optimizely/audience.rb
Outdated
| attributes ||= {} | ||
|
|
||
| custom_attr_condition_evaluator = CustomAttributeConditionEvaluator.new(attributes, logger) | ||
| custom_attr_condition_evaluator = CustomAttributeConditionEvaluator.new(user_context, logger) |
There was a problem hiding this comment.
Not sure if we should fix them all but this name is not good any more "CustomAttributeConditionEvaluator" since it evaluates more than custom-attributes. We can consider something like "ConditionEvaluator" or "UserConditionEvaluator".
| module Optimizely | ||
| class CustomAttributeConditionEvaluator | ||
| CUSTOM_ATTRIBUTE_CONDITION_TYPE = 'custom_attribute' | ||
| CONDITION_TYPES = %w[custom_attribute third_party_dimension].freeze |
There was a problem hiding this comment.
This is what I meant by name change. It's not "custom attribute" evaluator any more.
There was a problem hiding this comment.
Yea I agree, I made the change
zashraf1985
left a comment
zashraf1985
left a comment
There was a problem hiding this comment.
LGTM! Great work @andrewleap-optimizely
Summary
A new field
integrationsand new audience typeodp.audienceswill be added to the datafile schema for ODP integration.parse the odp values (
publicKeyandhost)accept datafile with and without the
integrationssection or empty section as well.support a new audience with the
odp.audiencesandqualifiedmatch.support any (allowed) combination of audiences, including ODP and other existing audiences.
Ticket:
OASIS-8393
Test plan
Added/extended tests in: