Add method and URL to Event, add method to EventDispatcher #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/optimizely/event_builder.rb
Outdated
|
|
||
| # Gets/Sets event params. | ||
| attr_accessor :params | ||
| attr_reader :method |
Contributor
There was a problem hiding this comment.
these all need docs. Method is not a very descriptive name. A developer seeing this might be tempted to pass in a function. Maybe method type or http verb/action is more suitable
Contributor
Author
There was a problem hiding this comment.
Good call, I like http_verb.
added 2 commits
August 29, 2016 11:06
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventEventDispatcher.dispatch_eventEventBuildertoEventBuilderV1BaseEventBuilderclass (https://github.com/bbatsov/ruby-style-guide#duck-typing)attr_accessorstoattr_readers@aliabbasrizvi @delikat @haleybash-optimizely @mikeng13 @alda-optimizely @wangjoshuah @jophde @jsm