Skip to content

feat(decision-listener): Incorporated new decision notification listener changes. #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aliabbasrizvi merged 1 commit into from
Apr 25, 2019
Merged

feat(decision-listener): Incorporated new decision notification listener changes. #173

aliabbasrizvi merged 1 commit into from
Apr 25, 2019

Conversation

@rashidsp
Copy link
Contributor

@rashidsp rashidsp commented Apr 25, 2019

Summary

  • Incorporated new decision notification listener changes.
  • Updated test data to fix experiment to feature relationship.

Test plan

  • Added unit tests for type feature-test and project config method.
  • Updated unit tests.

@coveralls
Copy link

coveralls commented Apr 25, 2019

Coverage Status

Coverage increased (+0.02%) to 99.011% when pulling 8495ee2 on rashid/decision-listener-new-changes into a116a3b on master.

@coveralls
Copy link

coveralls commented Apr 25, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.0007%) to 98.991% when pulling 8495ee2 on rashid/decision-listener-new-changes into a116a3b on master.

@rashidsp rashidsp requested a review from a team April 25, 2019 09:44
aliabbasrizvi
aliabbasrizvi approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@aliabbasrizvi aliabbasrizvi merged commit 1ca53d1 into master Apr 25, 2019
@aliabbasrizvi aliabbasrizvi deleted the rashid/decision-listener-new-changes branch April 25, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rashidsp @coveralls @aliabbasrizvi