Add SauceLabs browser testing to CI #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `Utils.isNumber` function, its not used in the codebase and isn't implemented correctly for IE when testing `new Number(1)`
jordangarcia
force-pushed
the
jordan/add-saucelabs-to-ci
branch
from
516e700 to
247dcac
Compare
|
Code LGTM, but I feel like we should add a few more browsers to be tested on SauceLabs. Perhaps 2-3 versions of Android, iOS, firefox and chrome. What do you think? |
|
@bhamodi This is a good start to browser coverage. I feel free to open a PR with more browsers. |
jordangarcia
added a commit
that referenced
this pull request
May 15, 2015
Add SauceLabs browser testing to CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@loganlinn @bhamodi
addresses #51