Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9559] Fix: Thread leak from httpClient in HttpProjectConfigManager #530

Merged
merged 1 commit into from
Aug 7, 2023
Merged

[FSSDK-9559] Fix: Thread leak from httpClient in HttpProjectConfigManager #530

merged 1 commit into from
Aug 7, 2023

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Aug 3, 2023

Summary

  • Added override close method in HttpProjectConfigManager to close httpClient

Test plan

All tests should pass

Issues

@mnoman09 mnoman09 requested a review from a team as a code owner August 3, 2023 13:20
@mnoman09 mnoman09 removed their assignment Aug 3, 2023
@muzahidul-opti
Copy link
Contributor

LGTM

@mnoman09 mnoman09 merged commit 9374090 into master Aug 7, 2023
@mnoman09 mnoman09 deleted the mnoman/FSSDK-9559 branch August 7, 2023 14:23
@russell-loube-optimizely russell-loube-optimizely mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muzahidul-opti muzahidul-opti muzahidul-opti approved these changes

Assignees
No one assigned
Labels
🤖 8 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnoman09 @muzahidul-opti @optimizely-codereview-bot @NomanShoaib