Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NotificationManager): add thread-safety to NotificationManager #460

Merged
merged 3 commits into from
Feb 3, 2022
Merged

fix(NotificationManager): add thread-safety to NotificationManager #460

merged 3 commits into from
Feb 3, 2022

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Jan 21, 2022

Summary

  • Fix NotificationManager to be thread-safe (add-handler and send-notifications can happen concurrently)

Test plan

  • Add a unit test concurrently adding handlers and sending notifications.

Issues

  • OASIS-8135

@jaeopt jaeopt requested a review from a team as a code owner January 21, 2022 01:48
@coveralls
Copy link

coveralls commented Jan 21, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1939

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 90.741%
Totals Coverage Status
Change from base Build 1936: 0.007%
Covered Lines: 4871
Relevant Lines: 5368
💛 - Coveralls

The-inside-man
The-inside-man approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@The-inside-man The-inside-man left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like just a lint issue in the test.

@jaeopt jaeopt merged commit d4c37ae into master Feb 3, 2022
@jaeopt jaeopt deleted the jae/notif-concurrent branch February 3, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-inside-man The-inside-man The-inside-man approved these changes

Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @coveralls @The-inside-man