-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-8957] Update non-code path resources for FX #366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
README.md
Outdated
@@ -69,26 +86,52 @@ optimizelyFactory := &client.OptimizelyFactory{ | |||
client, err = optimizelyFactory.Client() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code has issues too, can you replace it with the following:
// Simple one-line initialization with the SDK key
optlyClient, err := optly.Client("SDK_KEY")
// You can also instantiate with a hard-coded datafile using our client factory method
optimizelyFactory := &client.OptimizelyFactory{
Datafile: []byte("datafile_string"),
}
optlyClient, err = optimizelyFactory.Client()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w.r.t code samples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Update all non-code-path SDK resources for Feature Experimenation
Jira ticket: https://jira.sso.episerver.net/browse/FSSDK-8957