feat: add datafile accessor #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msohailhussain
requested changes
Aug 19, 2020
| @@ -48,6 +49,11 @@ type DatafileProjectConfig struct { | |||
| botFiltering bool | |||
| } | |||
|
|
|||
| // GetDatafile returns a JSON string representation of the environment's datafile | |||
There was a problem hiding this comment.
returns a string representation, datafile is itself in JSON, don't need to add that.
pkg/config/optimizely_config.go
Outdated
| datafile string | ||
| } | ||
|
|
||
| // GetDatafile returns a JSON string representation of the environment's datafile |
| @@ -17,13 +17,21 @@ | |||
| // Package config // | |||
| package config | |||
|
|
|||
| import "github.com/optimizely/go-sdk/pkg/entities" | |||
| import ( | |||
There was a problem hiding this comment.
please update header.
| @@ -62,17 +62,22 @@ func (s *OptimizelyConfigTestSuite) TestOptlyConfig() { | |||
| s.Equal(s.expectedOptimizelyConfig.FeaturesMap, optimizelyConfig.FeaturesMap) | |||
| s.Equal(s.expectedOptimizelyConfig.ExperimentsMap, optimizelyConfig.ExperimentsMap) | |||
| s.Equal(s.expectedOptimizelyConfig.Revision, optimizelyConfig.Revision) | |||
|
|
|||
| s.Equal(s.expectedOptimizelyConfig, *optimizelyConfig) | |||
pkg/config/static_manager_test.go
Outdated
| @@ -48,7 +48,9 @@ func TestNewStaticProjectConfigManagerFromPayload(t *testing.T) { | |||
|
|
|||
| func TestStaticGetOptimizelyConfig(t *testing.T) { | |||
|
|
|||
| mockDatafile := []byte(`{"accountId":"42","projectId":"123","version":"4"}`) | |||
| // since marshalling changes the order of keys in jsonString everytime, using json with a single key | |||
There was a problem hiding this comment.
why changed the payload, we are not supposed to change it.
There was a problem hiding this comment.
reverted this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing