Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: provide synchronization for Notification Center Cache #273

Merged
merged 3 commits into from
Jun 26, 2020
Merged

fix: provide synchronization for Notification Center Cache #273

merged 3 commits into from
Jun 26, 2020

Conversation

pawels-optimizely
Copy link
Contributor

Summary

  • provide synchronization for Notification Center Cache
  • this fix is for a case when many clients are initialized with different sdk keys ( Agent scenario)

@pawels-optimizely pawels-optimizely requested a review from a team as a code owner June 18, 2020 22:54
mikeproeng37
mikeproeng37 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37
Copy link
Contributor

Ah, should we add unit tests for it then?

@pawels-optimizely pawels-optimizely removed their assignment Jun 26, 2020
@pawels-optimizely pawels-optimizely merged commit c5ec0df into master Jun 26, 2020
@pawels-optimizely pawels-optimizely deleted the pawel/fix_sync_for_notification branch June 26, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawels-optimizely @mikeproeng37 @mjc1283