Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logger): Use exportable field names in log output. #246

Merged
merged 1 commit into from
Mar 26, 2020
Merged

fix(logger): Use exportable field names in log output. #246

merged 1 commit into from
Mar 26, 2020

Conversation

mikecdavis
Copy link
Contributor

Summary

  • Fixes the logging field keys to be consumable
  • Always include an "instance" field
  • Optionally include the SDK key

@mikecdavis mikecdavis requested a review from a team as a code owner March 25, 2020 23:09
thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecdavis mikecdavis merged commit 76ab49f into master Mar 26, 2020
@mikecdavis mikecdavis deleted the mikecdavis/fix-sdk-key-logging branch March 26, 2020 00:03
@mikecdavis mikecdavis mentioned this pull request Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Assignees

@mikecdavis mikecdavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikecdavis @thomaszurkan-optimizely