Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Method for removing forced variations #176

Merged
merged 1 commit into from
Nov 12, 2019
Merged

feat: Method for removing forced variations #176

merged 1 commit into from
Nov 12, 2019

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Nov 11, 2019

This adds a RemoveVariation method of MapExperimentOverridesStore, which can be used to delete a previously set variation.

@mjc1283 mjc1283 requested a review from a team as a code owner November 11, 2019 16:23
@mjc1283 mjc1283 removed their assignment Nov 11, 2019
mikeproeng37
mikeproeng37 approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjc1283 mjc1283 merged commit 0c62964 into master Nov 12, 2019
@mjc1283 mjc1283 deleted the mcarroll/remove-forced-variation branch November 12, 2019 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
🤖 12 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjc1283 @mikeproeng37 @optimizely-codereview-bot