Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add a public function to create a MapExperimentOverridesStore instance #174

Merged
merged 1 commit into from
Nov 8, 2019
Merged

fix: Add a public function to create a MapExperimentOverridesStore instance #174

merged 1 commit into from
Nov 8, 2019

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Nov 8, 2019

This adds a new function NewMapExperimentOverridesStore, so that MapExperimentOverridesStore can be used outside the decision package. Unit tests are updated to exercise NewMapExperimentOverridesStore.

@mjc1283 mjc1283 requested a review from a team as a code owner November 8, 2019 18:26
@mjc1283 mjc1283 removed their assignment Nov 8, 2019
mikeproeng37
mikeproeng37 approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjc1283 mjc1283 merged commit a2b7018 into master Nov 8, 2019
@mjc1283 mjc1283 deleted the mcarroll/public-map-experiment-overrides branch November 8, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjc1283 @mikeproeng37