Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check nil to prevent panic. #162

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Check nil to prevent panic. #162

merged 1 commit into from
Oct 31, 2019

Conversation

mikecdavis
Copy link
Contributor

Summary

  • Check nil feature to prevent panic
  • Use consistent variable name decisionContext to distinguish from userContext

After we made a distinction between fatal and non-fatal errors, we can no longer assume that the Feature exists as part of the DecisionContext. Now we must check.

@mikecdavis mikecdavis requested a review from a team as a code owner October 31, 2019 18:58
pawels-optimizely
pawels-optimizely approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikecdavis mikecdavis merged commit 0f77426 into master Oct 31, 2019
@mikecdavis mikecdavis deleted the mikecdavis/OASIS-5577-check-nil branch October 31, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

Assignees

@mikecdavis mikecdavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikecdavis @pawels-optimizely