Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9631] feat: add datafile syncer to synchronize datafile across agent nodes for webhook API #405

Merged
merged 18 commits into from
Dec 5, 2023

Conversation

pulak-opti
Copy link
Contributor

Summary

  • added datafile syncer

Issues

@pulak-opti pulak-opti marked this pull request as ready for review November 24, 2023 16:48
@pulak-opti pulak-opti changed the title [FSSDK-9631] feat: add datafile syncer [FSSDK-9631] feat: add datafile syncer across agent nodes for webhook API Nov 24, 2023
@pulak-opti pulak-opti changed the title [FSSDK-9631] feat: add datafile syncer across agent nodes for webhook API [FSSDK-9631] feat: add datafile syncer to sync datafile across agent nodes for webhook API Nov 27, 2023
@pulak-opti pulak-opti changed the title [FSSDK-9631] feat: add datafile syncer to sync datafile across agent nodes for webhook API [FSSDK-9631] feat: add datafile syncer to synchronize datafile across agent nodes for webhook API Nov 27, 2023
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of questions, but otherwise LGTM for my lack of Golang expertise.

cmd/optimizely/main.go Show resolved Hide resolved
config/config.go Show resolved Hide resolved
pkg/handlers/notification.go Outdated Show resolved Hide resolved
pkg/handlers/notification.go Show resolved Hide resolved
pkg/handlers/webhook_test.go Show resolved Hide resolved
pkg/handlers/webhook_test.go Show resolved Hide resolved
pkg/optimizely/cache.go Show resolved Hide resolved
pkg/handlers/webhook.go Show resolved Hide resolved
pkg/syncer/syncer.go Show resolved Hide resolved
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few small changes suggested.

pkg/syncer/pubsub.go Outdated Show resolved Hide resolved
pkg/handlers/webhook.go Outdated Show resolved Hide resolved
pkg/handlers/webhook.go Outdated Show resolved Hide resolved
pkg/handlers/notification.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good! One more round with a couple of more suggestions.

pkg/handlers/webhook.go Show resolved Hide resolved
config.yaml Outdated
@@ -245,15 +245,19 @@ runtime:
mutexProfileFraction: 0

## synchronization should be enabled when multiple replicas of agent is deployed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statement may be too strong. What about adding "when features for multiple nodes like notification streaming are deployed"?

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pulak-opti pulak-opti merged commit a06246f into master Dec 5, 2023
12 of 13 checks passed
@pulak-opti pulak-opti deleted the pulak/datafile-synchronization branch December 5, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants