Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9591] chore: bump go version to 1.21.0 #398

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

pulak-opti
Copy link
Contributor

@pulak-opti pulak-opti commented Aug 30, 2023

Summary

  • Update go version to 1.21.0

Test plan

  • Existing tests should pass

Note: One acceptance is failing for one data pair mismatched. Nothing to check on the agent's side. Need to check on the data provider side. We'll fix the test soon.

Ticket

@pulak-opti pulak-opti marked this pull request as ready for review September 7, 2023 16:52
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. New version of golangci linter is only 2 weeks old 👍. LGTM

@pulak-opti pulak-opti merged commit 794e827 into master Sep 7, 2023
12 of 13 checks passed
@pulak-opti pulak-opti deleted the pulak/go-version-update branch September 7, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants