Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue#345): Fixes an issue with oauth/token API denying client access. #346

Merged
merged 3 commits into from
Jan 12, 2023
Merged

fix(issue#345): Fixes an issue with oauth/token API denying client access. #346

merged 3 commits into from
Jan 12, 2023

Conversation

yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Sep 6, 2022 •
edited
Loading

Summary

  • Fixes an issue with /oauth/token api which restricted client access. The outer middleware only allowed application/json whereas internally it was again checking again for application/x-www-form-urlencoded.

Issues

@yasirfolio3 yasirfolio3 changed the title fixes an issue with token api's. fix(issue#345): Fixes an issue with oauth/token API denying client access. Sep 6, 2022
@msohailhussain msohailhussain marked this pull request as ready for review September 8, 2022 19:35
msohailhussain
msohailhussain approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Mat001
Mat001 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain reopened this Oct 5, 2022
msohailhussain
msohailhussain approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain merged commit eb56cf9 into master Jan 12, 2023
@msohailhussain msohailhussain deleted the yasir/fix-issue-345 branch January 12, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yasirfolio3 @Mat001 @msohailhussain