Streamline CI #234
Merged
Streamline CI #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
+ Coverage 82.55% 82.63% +0.07%
==========================================
Files 27 27
Lines 1261 1261
==========================================
+ Hits 1041 1042 +1
+ Misses 165 164 -1
Partials 55 55
Continue to review full report at Codecov.
|
aliabbasrizvi
approved these changes
Jun 15, 2020
pawels-optimizely
approved these changes
Jun 15, 2020
mikeproeng37
approved these changes
Jun 17, 2020
| @@ -30,5 +30,11 @@ exclude ( | |||
| github.com/coreos/etcd v3.3.12+incompatible | |||
| github.com/coreos/etcd v3.3.13+incompatible | |||
| github.com/coreos/etcd v3.3.15+incompatible | |||
| github.com/coreos/etcd v3.3.16+incompatible | |||
There was a problem hiding this comment.
Lol this seems a bit excessive
There was a problem hiding this comment.
Haha, yeah. There is a replace directive in go mod. And while it works to force 3.3.10 => 3.3.22 in a single line, srcclr doesn't appear to respect that and still flags the original version 3.3.10 which has even higher severity warnings.
mjc1283
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These markdown linters are adding more friction than the problem they aim to resolve so we removed them. We ran into build failures for RPM packages due to an insufficient ruby version so we opted to remove RPM and DEB builds until there is a demand. SourceClear started to flag an indirect dependency as a vulnerability, but unfortunately etcd @ v3.4.x is broken in go mod so the best we could do was bump to the latest 3.3.x version. Lastly, we needed to remove the cert pinning in the alpine docker build since that version was no longer available.
Ref: etcd-io/etcd#11154