Skip to content

Fix UnboundLocalError when stopping_criterion=None in convergence_plot #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janosg merged 5 commits into from
Jan 23, 2026
Merged

Fix UnboundLocalError when stopping_criterion=None in convergence_plot #659

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59fb50f
Fix stopping_criterion=None handling in convergence_plot
szd5654125 Dec 16, 2025
e030be6
Following maintainer feedback on PR #659, clarify that stopping_crite…
szd5654125 Dec 19, 2025
e79415d
Merge branch 'main' into fix-stopping-criterion-none
janosg Jan 23, 2026
5ca0e39
Fix line length
janosg Jan 23, 2026
4fb1fc0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/optimagic/benchmarking/process_benchmark_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,9 @@ def _process_one_result(
}

# calculate at which iteration the problem has been solved
if stopping_criterion is not None:
if stopping_criterion is None:
is_converged = False
else:
is_converged_x, x_idx = _check_convergence(params_dist_normalized, x_precision)
is_converged_y, y_idx = _check_convergence(normalized_crit_hist, y_precision)

Expand Down
15 changes: 8 additions & 7 deletions tests/optimagic/visualization/test_convergence_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,14 @@ def test_convergence_plot_options(options, grid, benchmark_results, close_mpl_fi
def test_convergence_plot_stopping_criterion_none(benchmark_results):
problems, results = benchmark_results

with pytest.raises(UnboundLocalError):
convergence_plot(
problems=problems,
results=results,
problem_subset=["bard_good_start"],
stopping_criterion=None,
)
fig = convergence_plot(
problems=problems,
results=results,
problem_subset=["bard_good_start"],
stopping_criterion=None,
)

assert fig is not None


def test_check_only_allowed_subset_provided_none():
Expand Down
Loading