-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode logo #479
Dark mode logo #479
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 92.98% 93.00% +0.01%
==========================================
Files 194 194
Lines 14659 14659
==========================================
+ Hits 13631 13633 +2
+ Misses 1028 1026 -2 ☔ View full report in Codecov by Sentry. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think the current dashboard is not pretty enough to be included on the front page of the documentation and the readme. Can you remove the gif in both places? We'll work on something better soon.
- The toctree on this page is too deep. I think we only want to show one level, i.e. "likelihood estimation" and "method of simulated moments (MSM) estimation"
- When dark-mode is active, the plots in notebooks are still shown in a light theme. QuantEcon has found a way to switch to a dark theme. Click on the change contrast symbol here to try it out. Do you think it would be super hard to add this?
Is this still the case? I did not see any problems. |
That's outdated and has been fixed. Thanks! |
Unfortunately, that's not straightforward. It seems like QuantEcon have developed their own docs template. I haven't seen any sphinx theme like In a static fashion, changing the import matplotlib.pyplot as plt
plt.style.use('dark_background') However, automatically switching between the light and dark theme is tricky. Locally, the workaround is modifying some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add dark mode logo to the navigation bar and on the main index page.
furo
theme