Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add estimagic logo to documentation page #467

Merged
merged 26 commits into from
Aug 13, 2023
Merged

Add estimagic logo to documentation page #467

merged 26 commits into from
Aug 13, 2023

Conversation

mpetrosian
Copy link
Member

No description provided.

@mpetrosian mpetrosian requested a review from timmens August 9, 2023 14:57
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #467 (c661dc7) into main (fcd95f1) will increase coverage by 0.47%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   92.50%   92.98%   +0.47%     
==========================================
  Files         194      193       -1     
  Lines       14711    14613      -98     
==========================================
- Hits        13609    13588      -21     
+ Misses       1102     1025      -77     
Files Changed Coverage Δ
src/estimagic/parameters/parameter_groups.py 100.00% <ø> (ø)
src/estimagic/optimization/tranquilo.py 88.88% <100.00%> (ø)

... and 2 files with indirect coverage changes

@timmens
Copy link
Member

timmens commented Aug 10, 2023

Okay, I'm just realizing that the img tag needs to be closed, since, otherwise the logo div spans much further than it should. On the attached image you see that the text below is also centered, this is because the centering in the logo div also applies to that section because the img tag is not closed.

@timmens timmens self-requested a review August 11, 2023 12:16
Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@timmens timmens self-requested a review August 11, 2023 16:22
@timmens timmens requested a review from janosg August 12, 2023 21:01
Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand why the mock import does not work for tranquilo, but at least the autodoc works now. I've also left the tranquilo_scalar change as it is, though I think it is not necessary to fix the bug.

@janosg
Copy link
Member

janosg commented Aug 13, 2023

I changed the name inside mark_minimizer back so we don't get a breaking change.

@janosg janosg merged commit 0db0e16 into main Aug 13, 2023
13 checks passed
@janosg janosg deleted the new-logo branch August 13, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants