Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in multistart with least-squares optimizers #411

Merged
merged 2 commits into from
Nov 19, 2022
Merged

Fix bug in multistart with least-squares optimizers #411

merged 2 commits into from
Nov 19, 2022

Conversation

janosg
Copy link
Member

@janosg janosg commented Nov 19, 2022

resolves #410

@janosg
Make sure criterion values are scalars when checking for convergence …
a416a0a 
…in multistart optimization, even if optimizer returns and array of residuals.
@janosg janosg mentioned this pull request Nov 19, 2022
Closed
@codecov
Copy link

codecov bot commented Nov 19, 2022 •
edited
Loading

Codecov Report

Merging #411 (20ae0f6) into main (737f4d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   92.86%   92.86%           
=======================================
  Files         223      223           
  Lines       17436    17443    +7     
=======================================
+ Hits        16192    16199    +7     
  Misses       1244     1244
Impacted Files Coverage Δ
tests/optimization/test_tiktak.py 93.25% <ø> (ø)
src/estimagic/optimization/tiktak.py 92.63% <100.00%> (+0.18%) ⬆️
tests/optimization/test_multistart.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@janosg janosg requested a review from timmens November 19, 2022 11:56
timmens
timmens approved these changes Nov 19, 2022
View reviewed changes
Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that we've found and solved the bug. Approved.

@timmens timmens merged commit 8ce1611 into main Nov 19, 2022
@timmens timmens deleted the multistart-bug branch November 19, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmens timmens timmens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in multistart with ls optimizers
2 participants
@janosg @timmens