Fix #638: Domain story progress #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rt4914
assigned veena14cs and nikitamarysolomanpvt and unassigned veena14cs and nikitamarysolomanpvt
|
Unassigning @veena14cs and @nikitamarysolomanpvt as I am having some second thoughts about this code. |
veena14cs
reviewed
Feb 13, 2020
domain/src/main/java/org/oppia/domain/topic/StoryProgressController.kt
Outdated
Show resolved
Hide resolved
veena14cs
reviewed
Feb 13, 2020
domain/src/main/java/org/oppia/domain/topic/StoryProgressController.kt
Outdated
Show resolved
Hide resolved
domain/src/test/java/org/oppia/domain/topic/StoryProgressControllerTest.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/domain/topic/StoryProgressController.kt
Outdated
Show resolved
Hide resolved
nikitamarysolomanpvt
assigned BenHenning and veena14cs and unassigned nikitamarysolomanpvt and veena14cs
BenHenning
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
Thanks @rt4914! Generally LGTM--I just had a bunch of nits. Feel free to reassign to me or follow up if you have any additional questions or concerns.
domain/src/main/java/org/oppia/domain/topic/StoryProgressController.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/domain/topic/StoryProgressController.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/domain/topic/StoryProgressController.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/domain/topic/StoryProgressController.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/domain/topic/TopicListController.kt
Outdated
Show resolved
Hide resolved
domain/src/test/java/org/oppia/domain/topic/StoryProgressControllerTest.kt
Outdated
Show resolved
Hide resolved
domain/src/test/java/org/oppia/domain/topic/StoryProgressControllerTest.kt
Outdated
Show resolved
Hide resolved
domain/src/test/java/org/oppia/domain/topic/StoryProgressControllerTest.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design Doc: https://docs.google.com/document/d/1pAB0KxDwFianJ1zBgonmvak0_Rih-lNGBuwjkd6Jr28/edit#
Domain layer code of
StoryProgressControllerExplanation
Checklist