Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part #530: topic play dashed line issue fix in pre lollipop devices #627

Merged
merged 3 commits into from
Jan 28, 2020
Merged

Fix part #530: topic play dashed line issue fix in pre lollipop devices #627

merged 3 commits into from
Jan 28, 2020

Conversation

nikitamarysolomanpvt
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt commented Jan 27, 2020 •
edited
Loading

Explanation

Topic play dashed line issue fix in pre lollipop devices- tested in 4.4.2 (Kitkat)

Before

Untitled

  • Dashed lines

Current UI

small

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@nikitamarysolomanpvt nikitamarysolomanpvt mentioned this pull request Jan 27, 2020
Closed
22 tasks
@nikitamarysolomanpvt
Copy link
Contributor Author

@rajat your dev log issue mentioned below is addressed

21st January
Topic play dashed line issue (Dashed line becomes single line in kitkat) -> No solution found and also, there is no trace of any such error on stackoverflow also.

rt4914
rt4914 approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit change suggested.

app/src/main/java/org/oppia/app/topic/play/StorySummaryAdapter.kt Outdated Show resolved Hide resolved
veena14cs
veena14cs approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@veena14cs veena14cs removed their assignment Jan 28, 2020
@nikitamarysolomanpvt nikitamarysolomanpvt merged commit 3cf1964 into develop Jan 28, 2020
@nikitamarysolomanpvt nikitamarysolomanpvt deleted the topic-play-dashed-line-issue-fix branch January 28, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@veena14cs veena14cs veena14cs approved these changes

Assignees

@nikitamarysolomanpvt nikitamarysolomanpvt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikitamarysolomanpvt @rt4914 @veena14cs