Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning Fix: Updated use of parseHtml function #589

Merged
merged 3 commits into from
Jan 6, 2020
Merged

Warning Fix: Updated use of parseHtml function #589

merged 3 commits into from
Jan 6, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jan 6, 2020

Explanation

This PR fixes the warning in parseHtml function.
Reference: https://stackoverflow.com/a/37905107

Also, to check this PR correctly, run TopicListControllerTest and run the app and check that the HomeActivity is displayed correctly.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

nikitamarysolomanpvt
nikitamarysolomanpvt approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Jan 6, 2020
veena14cs
veena14cs reviewed Jan 6, 2020
View reviewed changes
domain/src/main/java/org/oppia/domain/topic/TopicListController.kt
} else {
Html.fromHtml(html) as Spannable
}
return HtmlCompat.fromHtml(html, HtmlCompat.FROM_HTML_MODE_LEGACY) as Spannable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this in HtmlParser class too under utility package.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Jan 6, 2020
veena14cs
veena14cs reviewed Jan 6, 2020
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update all the files that uses Html.fromHtml() function.

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Jan 6, 2020
veena14cs
veena14cs approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Jan 6, 2020
@rt4914 rt4914 merged commit e975d15 into develop Jan 6, 2020
@rt4914 rt4914 deleted the optimise-warnings-1 branch January 6, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veena14cs veena14cs veena14cs approved these changes

@nikitamarysolomanpvt nikitamarysolomanpvt nikitamarysolomanpvt approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rt4914 @veena14cs @nikitamarysolomanpvt