Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing purpose ( Do not Merge ) #5562

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from
Open

Testing purpose ( Do not Merge ) #5562

wants to merge 24 commits into from

Conversation

subhajitxyz
Copy link
Collaborator

Explanation

Testing purpose

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

subhajitxyz and others added 18 commits July 23, 2024 12:12
@subhajitxyz
Merge pull request #1 from oppia/develop
d819e70 
Develop (fork) Branch Update
@subhajitxyz
Merge branch 'oppia:develop' into develop
c6f54ea
@subhajitxyz
Merge remote-tracking branch 'upstream/develop' into develop
d44015b
@subhajitxyz
Merge pull request #2 from oppia/develop
d604bc2 
Develop (fork) Branch Update #2
@subhajitxyz
Merge pull request #3 from oppia/develop
cc0ddef 
Develop (fork) Branch Update
@subhajitxyz
Merge pull request #4 from oppia/develop
52c6bb1 
Develop(fork) branch update
@subhajitxyz
Merge remote-tracking branch 'upstream/develop' into develop
773c810
@subhajitxyz
Merge pull request #5 from oppia/develop
56af5ae 
Develop (fork) Branch Update
@subhajitxyz
Merge pull request #6 from oppia/develop
3883f70 
Develop (fork) Branch Update
@dattasneha @adhiamboperes
@theMr17 @subhajitxyz
Fix oppia#5404: Migrate away from onBackPressed for remaining activit…
10c8e6e 
…ies (oppia#5526)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->
 Fixes oppia#5404 

This PR migrates deprecated `onBackPressed` usage to
`OnBackPressedDispatcher` callback in the following activities and
presenters.

- ProfileEditActivity
- ProfileEditActivityPresenter
- QuestionPlayerActivityPresenter
- WalkthroughFinalFragmentPresenter

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- For PRs introducing new UI elements or color changes, both light and
dark mode screenshots must be included
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing

---------

Co-authored-by: Adhiambo Peres <[email protected]>
Co-authored-by: Mr. 17 <[email protected]>
@dattasneha @subhajitxyz
Fix oppia#5404: Migrate away from onBackPressed for RevisionCardActiv…
5e140e9 
…ity (oppia#5548)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->
Fixes oppia#5404 

This PR migrates deprecated `onBackPressed `usage to
`OnBackPressedDispatcher` callback in the RevisonCardActivity and
RevisionCardActivityPresenter.
## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- For PRs introducing new UI elements or color changes, both light and
dark mode screenshots must be included
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
@subhajitxyz
Merge branch 'oppia:develop' into develop
b4ad7a3
@subhajitxyz
check todo works proper
f1d576d
@subhajitxyz
correct formatting
fbf5249
@subhajitxyz
correct format
de91d66
@subhajitxyz
hi
f26b7be
@subhajitxyz
hi
6034262
@subhajitxyz
hi
2cf4bed
@subhajitxyz subhajitxyz requested review from a team as code owners October 31, 2024 14:44
@github-actions GitHub Actions
Copy link

Coverage Report

Results

Number of files assessed: 2
Overall Coverage: 83.05%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage
File Coverage Lines Hit Status Min Required
ApplicationLifecycleObserver.ktdomain/src/main/java/org/oppia/android/domain/oppialogger/analytics/ApplicationLifecycleObserver.kt
 83.05% 98 / 118 ✅ 70%

Exempted coverage

Files exempted from coverage
File Exemption Reason
GitHubService.ktscripts/src/java/org/oppia/android/scripts/common/remote/GitHubService.kt
 This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning Awaiting requested review from BenHenning BenHenning is a code owner automatically assigned from oppia/android-dev-workflow-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subhajitxyz @dattasneha