Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #47: Replaces Gravatar with Avatars with colored backgrounds #554

Merged
merged 166 commits into from
Dec 14, 2019

Conversation

jamesxu0
Copy link
Contributor

@jamesxu0 jamesxu0 commented Dec 14, 2019

Explanation

Fixes #47: Replaces Gravatar with Avatars with colored backgrounds. I had to create a new PR because I accidently merged the old PR #539 into my own branch instead of develop.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @BenHenning's approval of #539. There are three slight differences from that PR in import statements and ordering (see app/src/main/AndroidManifest.xml, app/src/main/java/org/oppia/app/profile/AdminSettingsDialogFragmentPresenter.kt) but the current version looks fine to me.

@jamesxu0 jamesxu0 merged commit 9db3af7 into develop Dec 14, 2019
@seanlip seanlip deleted the profile-avatar-colors branch December 17, 2019 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gravitars/avatar rendering [Blocked: #44]
3 participants