-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #5344: Refactor Classroom List Screen UI #5462
Conversation
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 4344 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 5297 bytes (Added) Method count: 258445 (old), 258447 (new), 2 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6787 (new), 12 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 4184 bytes (Added)
Configuration hdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration ldpiAPK file size: 48 KiB (old), 48 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 85 KiB (old), 85 KiB (new), 140 bytes (Added) Configuration xhdpiAPK file size: 56 KiB (old), 56 KiB (new), 100 bytes (Added) Configuration xxhdpiAPK file size: 62 KiB (old), 62 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 43 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 40 KiB (Added) Method count: 114844 (old), 115410 (new), 566 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 43 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 43 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 40 KiB (Added) Method count: 114850 (old), 115416 (new), 566 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 43 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 43 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 41 KiB (Added) Method count: 114850 (old), 115416 (new), 566 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 43 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 4412 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 5118 bytes (Added) Method count: 258445 (old), 258458 (new), 13 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6787 (new), 12 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 4256 bytes (Added)
Configuration hdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration ldpiAPK file size: 48 KiB (old), 48 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 85 KiB (old), 85 KiB (new), 140 bytes (Added) Configuration xhdpiAPK file size: 56 KiB (old), 56 KiB (new), 100 bytes (Added) Configuration xxhdpiAPK file size: 62 KiB (old), 62 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 44 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 41 KiB (Added) Method count: 114844 (old), 115417 (new), 573 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 43 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 43 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 41 KiB (Added) Method count: 114850 (old), 115423 (new), 573 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 43 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 43 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 40 KiB (Added) Method count: 114850 (old), 115423 (new), 573 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 43 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) |
This PR is now ready for a review, @adhiamboperes PTAL. |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 3832 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 2622 bytes (Added) Method count: 258691 (old), 258707 (new), 16 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6787 (new), 12 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 3672 bytes (Added)
Configuration hdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration ldpiAPK file size: 48 KiB (old), 48 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 85 KiB (old), 85 KiB (new), 140 bytes (Added) Configuration xhdpiAPK file size: 56 KiB (old), 56 KiB (new), 100 bytes (Added) Configuration xxhdpiAPK file size: 62 KiB (old), 62 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 47 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 46 KiB (Added) Method count: 114909 (old), 115482 (new), 573 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 11 MiB (new), 47 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 47 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 43 KiB (Added) Method count: 114915 (old), 115488 (new), 573 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 47 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 47 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 42 KiB (Added) Method count: 114915 (old), 115488 (new), 573 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 47 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) |
Thanks @theMr17!
|
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 4064 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 2274 bytes (Added) Method count: 258691 (old), 258707 (new), 16 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6787 (new), 12 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 3908 bytes (Added)
Configuration hdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration ldpiAPK file size: 48 KiB (old), 48 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 85 KiB (old), 85 KiB (new), 140 bytes (Added) Configuration xhdpiAPK file size: 56 KiB (old), 56 KiB (new), 100 bytes (Added) Configuration xxhdpiAPK file size: 62 KiB (old), 62 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 47 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 46 KiB (Added) Method count: 114909 (old), 115482 (new), 573 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 11 MiB (new), 47 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 47 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 43 KiB (Added) Method count: 114915 (old), 115488 (new), 573 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 47 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 47 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 42 KiB (Added) Method count: 114915 (old), 115488 (new), 573 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 47 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) |
1 similar comment
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 4064 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 2274 bytes (Added) Method count: 258691 (old), 258707 (new), 16 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6787 (new), 12 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 3908 bytes (Added)
Configuration hdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration ldpiAPK file size: 48 KiB (old), 48 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 85 KiB (old), 85 KiB (new), 140 bytes (Added) Configuration xhdpiAPK file size: 56 KiB (old), 56 KiB (new), 100 bytes (Added) Configuration xxhdpiAPK file size: 62 KiB (old), 62 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 47 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 46 KiB (Added) Method count: 114909 (old), 115482 (new), 573 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 11 MiB (new), 47 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 47 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 43 KiB (Added) Method count: 114915 (old), 115488 (new), 573 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 47 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 47 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 42 KiB (Added) Method count: 114915 (old), 115488 (new), 573 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5755 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 47 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 7824 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 5499 bytes (Added) Method count: 259120 (old), 259143 (new), 23 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6788 (old), 6803 (new), 15 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 7668 bytes (Added)
Configuration hdpiAPK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Added) Configuration ldpiAPK file size: 49 KiB (old), 49 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 86 KiB (old), 86 KiB (new), 140 bytes (Added) Configuration xhdpiAPK file size: 57 KiB (old), 57 KiB (new), 100 bytes (Added) Configuration xxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 45 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 40 KiB (Added) Method count: 115112 (old), 115689 (new), 577 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5758 (old), 5770 (new), 12 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 11 MiB (new), 45 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 45 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 41 KiB (Added) Method count: 115108 (old), 115695 (new), 587 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5758 (old), 5770 (new), 12 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 45 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 45 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 37 KiB (Added) Method count: 115108 (old), 115695 (new), 587 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5758 (old), 5770 (new), 12 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 45 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) |
1 similar comment
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 7824 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 5499 bytes (Added) Method count: 259120 (old), 259143 (new), 23 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6788 (old), 6803 (new), 15 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 7668 bytes (Added)
Configuration hdpiAPK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Added) Configuration ldpiAPK file size: 49 KiB (old), 49 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 86 KiB (old), 86 KiB (new), 140 bytes (Added) Configuration xhdpiAPK file size: 57 KiB (old), 57 KiB (new), 100 bytes (Added) Configuration xxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 45 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 40 KiB (Added) Method count: 115112 (old), 115689 (new), 577 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5758 (old), 5770 (new), 12 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 11 MiB (new), 45 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 45 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 41 KiB (Added) Method count: 115108 (old), 115695 (new), 587 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5758 (old), 5770 (new), 12 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 45 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 45 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 37 KiB (Added) Method count: 115108 (old), 115695 (new), 587 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5758 (old), 5770 (new), 12 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 45 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) |
Hi @adhiamboperes, sorry for being unclear. Yes, I think your interpretation of my feedback is correct overall. I was initially referring to the dark mode designs since they were the only ones available at the time I looked at this PR. I will take a look at the updated videos now. |
@theMr17 @adhiamboperes OK, here are my remaining comments/concerns (@ashley-ya it would be helpful to get your feedback on these as well!):
Otherwise, no issues from my end. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17! Code changes LGTM.
Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Hi @seanlip, per suggestion, I tried to remove the bottom border, but I realized that Jetpack Compose does not support that. We cannot add borders only to the top, start, and end; we can either add borders to all sides or not add them at all. |
Hi @theMr17 great work on the multiple classrooms tab and animation! A few tweaks to the UI to improve the interface clarity:
It can also be found in the figma file: https://www.figma.com/design/H4BaHlwnALtjQcemP322hE/Oppia-Multiple-Classroom-Android-(Ashley's-Expansion)?node-id=3168-3352&t=te0J1N9h83aZb9PK-1 Thanks again for your work on this! |
Apologies for the delay. I see your point of moving towards a design that clearly connects the classrooms and their related topics. The issue I see is that once the user selects a classroom, the selected tab background and topics section background wouldn't be the same color and the lack of border may appear strange. With the information Saptak shared about the border options, I think the design might need more UI rework to see how it could function without any tab borders. So I'm proposing we keep the style for now |
Thanks @ashley-ya for the new dark mode icon. Moving ahead with the same style for now! |
@adhiamboperes PTAL at the latest code changes and the updated screenshots and recordings. |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 8192 bytes (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 4847 bytes (Added) Method count: 259120 (old), 259143 (new), 23 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6788 (old), 6806 (new), 18 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 8032 bytes (Added)
Configuration hdpiAPK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Added) Configuration ldpiAPK file size: 49 KiB (old), 49 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 80 bytes (Added) Configuration tvdpiAPK file size: 86 KiB (old), 86 KiB (new), 140 bytes (Added) Configuration xhdpiAPK file size: 57 KiB (old), 57 KiB (new), 100 bytes (Added) Configuration xxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 80 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 46 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 35 KiB (Added) Method count: 115112 (old), 115689 (new), 577 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5758 (old), 5774 (new), 16 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 11 MiB (new), 46 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 46 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 41 KiB (Added) Method count: 115108 (old), 115695 (new), 587 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5758 (old), 5774 (new), 16 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 45 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 45 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 37 KiB (Added) Method count: 115108 (old), 115695 (new), 587 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5758 (old), 5774 (new), 16 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 45 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 60 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 100 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 60 bytes (Added) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 100 bytes (Added) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 80 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 60 bytes (Added) |
Thanks @ashley-ya! @theMr17 @adhiamboperes FYI I'm happy with this getting merged as long as @ashley-ya's comments are addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17! This LGTM.
Explanation
Fixes part of #5344
This PR refactors the new Classroom List Screen to align with the updated design mocks provided in Figma. The changes include:
ScreenRecordingLightMode.mp4
ScreenRecordingDarkMode.mp4
Screenshots
Phone
Tablet
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: