Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of 44: High-fi Profile Selection page #525

Merged
merged 5 commits into from
Dec 9, 2019
Merged

Fix part of 44: High-fi Profile Selection page #525

merged 5 commits into from
Dec 9, 2019

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Dec 6, 2019 •
edited
Loading

Explanation

This PR corresponds to UI of Profile selection page.

Mock

https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/ad1de6e2-1d5d-4ac3-888c-58d036c7ede4/PC-MP-Profile-Chooser-

Accessibility Scanner

  • Passes Accessibility Scanner test

Screenshot

Screenshot_20191206-154901

rt4914
rt4914 approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made a commit to fix somes issues in this. LGTM

@nikitamarysolomanpvt Please verify this as me and @veena14cs both have worked on this.

app/src/main/res/layout/profile_chooser_fragment.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 removed their assignment Dec 6, 2019
@nikitamarysolomanpvt
Copy link
Contributor

Last used/visited time is missing. @veena14cs please make sure this is not missed in future.

nikitamarysolomanpvt
nikitamarysolomanpvt approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mschanteltc iam not able to find the attributes of Administration label in the mock. PTAL .
Beside this LGTM

@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Dec 9, 2019
nikitamarysolomanpvt
nikitamarysolomanpvt suggested changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untitled

PTAL

@veena14cs veena14cs self-assigned this Dec 9, 2019
@veena14cs
Copy link
Contributor Author

Untitled

PTAL

Fixed PTAL
Screenshot_20191209-122231

@veena14cs
Copy link
Contributor Author

veena14cs commented Dec 9, 2019 •
edited
Loading

Last used/visited time is missing. @veena14cs please make sure this is not missed in future.

This needs to be fixed in low-fi issue. I have filed an issue related to this #531 thanks for noting it.

nikitamarysolomanpvt
nikitamarysolomanpvt approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veena14cs veena14cs merged commit 04215e7 into develop Dec 9, 2019
@veena14cs veena14cs deleted the hifi-select-profile branch December 9, 2019 07:49
@mschanteltc
Copy link

@mschanteltc iam not able to find the attributes of Administration label in the mock. PTAL .
Beside this LGTM

You can find the attributes of Administrator label on this mock. Would it also be possible to include the time stamp of when each user last used the app? (Example: "Last used 4 hours ago")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@nikitamarysolomanpvt nikitamarysolomanpvt nikitamarysolomanpvt approved these changes

Assignees

@veena14cs veena14cs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@veena14cs @nikitamarysolomanpvt @mschanteltc @rt4914