[Android Wiki] Added "Tips and Tricks" for android wiki contribution #4921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohitGupta121
commented
Mar 25, 2023
There was a problem hiding this comment.
@gp201 @BenHenning PTAL, I make changes for preview as we discuss.
MohitGupta121
changed the title
gp201
suggested changes
Mar 27, 2023
MohitGupta121
commented
Mar 28, 2023
BenHenning
requested changes
Mar 30, 2023
There was a problem hiding this comment.
Thanks @MohitGupta121! I really like the idea of including tips & tricks, and especially the one that you're adding, but I do have some concerns with the steps that need to be followed. PTAL.
MohitGupta121
commented
Mar 31, 2023
There was a problem hiding this comment.
@BenHenning PTAL, I updated the wiki and added TODO issue but getting TODO Regex error, I try it on my local system to run the TODO bazel test but not able to test it in local and not able to find why it's failing even I use exact pattern for TODO.
Thanks.
This command I use to run the TODO test, I also get open_issues.json as per mention in this comments.
bazel run //scripts:todo_open_check -- $(pwd) scripts/assets/todo_open_exemptions.pb open_issues.json
BenHenning
reviewed
Mar 31, 2023
MohitGupta121
commented
Mar 31, 2023
BenHenning
approved these changes
Mar 31, 2023
Uticodes
pushed a commit
to Uticodes/oppia-android
that referenced
this pull request
Apr 4, 2023
…ppia#4921) <!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation [Android Wiki] Added "Tips and Tricks" for android wiki contribution - Tips for Wiki Markdown Preview in Android Studio <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
[Android Wiki] Added "Tips and Tricks" for android wiki contribution
Essential Checklist