Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #433: Add content and change the thumbnail image for the ratios concept card #492

Merged
merged 4 commits into from
Dec 3, 2019

Conversation

vinitamurthi
Copy link
Contributor

Explanation

This PR changes the content of the ratios concept card and also adds a new thumbnail for it.
Thumbnail Image:
Screenshot_1575074658
Concept card content:
Screenshot_1575074655

Fixes #433

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vinitamurthi vinitamurthi removed their assignment Nov 30, 2019
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my end (just with regards to the data added), thanks @vinitamurthi!

@seanlip seanlip removed their assignment Dec 1, 2019
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vinitamurthi!

@BenHenning BenHenning assigned vinitamurthi and unassigned BenHenning Dec 2, 2019
@BenHenning BenHenning merged commit 5b0d9cf into develop Dec 3, 2019
@BenHenning BenHenning deleted the ratios branch December 3, 2019 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derive a ratio concept card picture & content is wrong
4 participants