Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #3557: Merge profile chooser xml #4849

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

masclot
Copy link
Collaborator

@masclot masclot commented Jan 20, 2023

Explanation

Fix part of #3557: Merges landscape and portrait versions of profile_chooser_fragment.xml for sw600 screens.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Portrait after:
portrait-new

Portrait before:
portrait-current

Landscape after:
landscape-new

Landscape before:
landscape-current

ProfileChooserSpanTest results:
ProfileChooserSpanTest results

ProfileChooserFragmentTest results:
ProfileChooserFragmentTest

ProfileChooserFragmentTest on tablet:
ProfileChooserFragmentTest on tablet

ProfileChooserActivityTest on tablet:
ProfileChooserActivityTest on tablet

Tablet portrait before:
Tablet portrait before

Tablet portrait after:
Tablet portrait after

Tablet landscape before:
tablet landscape before

Tablet landscape after:
Tablet landscape after

Tablet RTL portrait before:
tablet RTL portrait before

Tablet RTL portrait after:
Tablet RTL portrait after

Tablet RTL landscape before:
Tablet RTL landscape before

Tablet RTL landscape after:
Tablet RTL landscape after

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@rt4914 rt4914 enabled auto-merge (squash) January 27, 2023 17:02
@oppiabot oppiabot bot unassigned rt4914 Jan 27, 2023
@oppiabot
Copy link

oppiabot bot commented Jan 27, 2023

Unassigning @rt4914 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jan 27, 2023
@rt4914 rt4914 merged commit d9f2d81 into oppia:develop Jan 27, 2023
@masclot masclot deleted the merge-profile-chooser-xml branch February 3, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants