-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4624, #4741, #4461 : Dark mode implementation - Topic Lessons, Topic Revision, Revision Card, Story Activity, Resume Lesson #4796
Fixes #4624, #4741, #4461 : Dark mode implementation - Topic Lessons, Topic Revision, Revision Card, Story Activity, Resume Lesson #4796
Conversation
@rt4914 I added changes as per your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed again. Reply to all open comments after changes.
@rt4914 update the changes as per review and screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks. Great work.
…ext, and change button name"" (#5090) Fixes #5088. Reverts #4987 which removed styles and added changes that broke the dark mode support previously correctly implmented in #4796. This is a clean revert so it can be merged directly. | Before - Light Mode | Before - Dark Mode | | ------ | ------ | | <img src="https://github.com/oppia/oppia-android/assets/76530270/8494dcd1-c8cf-441a-9cea-305cc1afdb1e" height="400" style="max-width: 100%"> | <img src="https://github.com/oppia/oppia-android/assets/76530270/e823a67e-3eb2-4f4d-86c1-7bbcb4bd4380" height="400" style="max-width: 100%"> | | After - Light Mode | After - Dark Mode | | ------ | ------ | | <img src="https://github.com/oppia/oppia-android/assets/76530270/9651500d-3434-4d44-b2b4-9ea3b28c072b" height="400" style="max-width: 100%"> | <img src="https://github.com/oppia/oppia-android/assets/76530270/bba4d86f-2ea8-4401-9e81-6d8d3318ac5f" height="400" style="max-width: 100%"> | | Before - Dark Mode Landscape | After - Dark Mode Landscape | | ------ | ------ | | <img src="https://github.com/oppia/oppia-android/assets/76530270/36d3fb9d-3388-4c78-ba57-c932f360a7b0" > | <img src="https://github.com/oppia/oppia-android/assets/76530270/143434c9-6288-4d44-8390-c4d55f28fc40"> | | Before - Dark Mode Tab | After - Dark Mode Tab | | ------ | ------ | | <img src="https://github.com/oppia/oppia-android/assets/76530270/a4155c3f-ec4e-4b82-b113-eb7739af70e5" > | <img src="https://github.com/oppia/oppia-android/assets/76530270/ff604777-1581-41b7-b738-337814c9ac73" > |
Explanation
Dark mode implementation - Topic Lessons, Topic Revision, Revision Card, Story Activity, Resume Lesson
Fixes #4624 : Add dark mode support to Lesson Tab
Fixes #4741 : Contrast issue in Continue Studying text on revision screen
Fixes #4461 : TextView & Toolbar color changes in Topic screen
Essential Checklist
For UI-specific PRs only
Topic Lessons
Topic Revision
Revision Card
Story Activity
Resume Lesson
If your PR includes UI-related changes, then: