Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4431: Refactor LearnerStudyAnalytics to EnableLearnerStudyAnalytics #4782

Merged
merged 9 commits into from
Jan 13, 2023
Merged

Fix #4431: Refactor LearnerStudyAnalytics to EnableLearnerStudyAnalytics #4782

merged 9 commits into from
Jan 13, 2023

Conversation

pratyaksh1610
Copy link
Contributor

Explanation

Fix #4431
Refactor LearnerStudyAnalytics to EnableLearnerStudyAnalytics

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@pratyaksh1610 pratyaksh1610 mentioned this pull request Dec 9, 2022
Closed
6 tasks
BenHenning
BenHenning requested changes Dec 13, 2022
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pratyaksh1610! Overall the PR looks pretty good to me. Just had a few small nits. Also, could you please make sure CI is fully passing before sending this back into review?

domain/src/main/java/org/oppia/android/domain/profile/ProfileManagementController.kt Show resolved Hide resolved
utility/src/test/java/org/oppia/android/util/logging/EventBundleCreatorTest.kt Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Dec 20, 2022

Hi @pratyaksh1610, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 20, 2022
@oppiabot oppiabot bot closed this Dec 27, 2022
@pratyaksh1610 pratyaksh1610 reopened this Dec 28, 2022
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 28, 2022
@oppiabot
Copy link

oppiabot bot commented Jan 4, 2023

Hi @pratyaksh1610, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 4, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 11, 2023
BenHenning
BenHenning approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pratyaksh1610! Apologies for the delay. The PR LGTM. The CI failure seems like a flake, so I'm expecting it to pass with the re-run I just kicked off by syncing the PR with the latest develop changes.

@BenHenning BenHenning enabled auto-merge (squash) January 13, 2023 19:24
@oppiabot
Copy link

oppiabot bot commented Jan 13, 2023

Unassigning @BenHenning since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Jan 13, 2023

Assigning @rt4914 for code owner reviews. Thanks!

@BenHenning
Copy link
Member

Weird, compute_affected_tests failed. Haven't seen that in a while; going to assume it's a rare one-off flake for now & restart it.

@BenHenning BenHenning merged commit 0ba4fae into oppia:develop Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning BenHenning approved these changes

@rt4914 rt4914 Awaiting requested review from rt4914

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor LearnerStudyAnalytics to EnableLearnerStudyAnalytics
3 participants
@pratyaksh1610 @BenHenning @rt4914