Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #324: Submit answer upon keyboard enter #476

Merged
merged 13 commits into from
Nov 26, 2019

Conversation

veena14cs
Copy link
Contributor

Explanation

This PR submits the answer upon keyboard enter.

Note: Validation is not yet done on textinput interactions as per #376.

@veena14cs veena14cs changed the title Fix #324: Submit the answer upon keyboard enter Fix #324: Submit answer upon keyboard enter Nov 26, 2019
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nit changes suggested.

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Nov 26, 2019
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veena14cs veena14cs merged commit 3e60a1c into develop Nov 26, 2019
@veena14cs veena14cs deleted the keyboad-enter-button-fix branch November 26, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants