-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4756: Add support for logging an invested engagement event #4757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'Invested engagement' means that the user has spent enough time in a single play session to be considered well-engaged at that point in time.
BenHenning
changed the title
Fix #4756: Add support for logging an invested engagement event.
Fix #4756: Add support for logging an invested engagement event
Nov 23, 2022
@seanlip PTAL for review. I'm assigning this a bit earlier than CI full running to try and parallelize things a bit (since I'm hoping to get the PR cherry-picked and pushed to Play Store testing tonight). |
seanlip
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @BenHenning! I like the name.
Thanks @seanlip! |
BenHenning
added
the
PR: Cherrypick requested
Indicates that a PR is being requested for being cherrypicked into the ongoing release branch.
label
Nov 23, 2022
BenHenning
added a commit
that referenced
this pull request
Nov 23, 2022
## Explanation Fixes #4756 This PR introduces a new event for tracking individual play sessions where a learner has reached a level of 'invested' engagement, where 'invested' here is considered to be strong engagement with a likelihood of continuing at least with that play session. This metric is planned to be used as one of the team's conversion metrics to better help track the user marketing pipeline by helping to determine how we can better reach learners who are more likely to reach this level of engagement with lessons (and, thus, hopefully learn what they need to). Note that the event is based on a single play session, not a profile or even a single exploration (so if a user pauses and resumes an exploration, the count for engagement resets **from that point**). Engagement means completing _and_ moving past at minimum 3 cards (which may just be simple 'Continue' button interactions). For simplicity, this PR keeps the new event name the same between the Kenya & non-Kenya styles of naming events. I've verified that the event is logging as expected using Firebase's DebugView: ![image](https://user-images.githubusercontent.com/12983742/203501899-dbccd386-4e04-4966-82bc-a4646b3b742c.png) ## Essential Checklist - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only This PR is introducing a log and has no impact on the UI or UX of the app.
BenHenning
added
the
PR: Cherrypick completed
Indicates a cherrypick request was approved & completed for a PR.
label
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: Cherrypick completed
Indicates a cherrypick request was approved & completed for a PR.
PR: Cherrypick requested
Indicates that a PR is being requested for being cherrypicked into the ongoing release branch.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #4756
This PR introduces a new event for tracking individual play sessions where a learner has reached a level of 'invested' engagement, where 'invested' here is considered to be strong engagement with a likelihood of continuing at least with that play session.
This metric is planned to be used as one of the team's conversion metrics to better help track the user marketing pipeline by helping to determine how we can better reach learners who are more likely to reach this level of engagement with lessons (and, thus, hopefully learn what they need to).
Note that the event is based on a single play session, not a profile or even a single exploration (so if a user pauses and resumes an exploration, the count for engagement resets from that point). Engagement means completing and moving past at minimum 3 cards (which may just be simple 'Continue' button interactions).
For simplicity, this PR keeps the new event name the same between the Kenya & non-Kenya styles of naming events.
I've verified that the event is logging as expected using Firebase's DebugView:
Essential Checklist
For UI-specific PRs only
This PR is introducing a log and has no impact on the UI or UX of the app.