Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #407: Submit button should be visible above keyboard #469

Merged
merged 8 commits into from
Nov 27, 2019
Merged

Fix #407: Submit button should be visible above keyboard #469

merged 8 commits into from
Nov 27, 2019

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Nov 22, 2019 •
edited
Loading

Explanation

This PR fixes the submit button visibility above keyboard.

Screenshot

untitled

@veena14cs veena14cs requested review from rt4914 and nikitamarysolomanpvt and removed request for rt4914 November 22, 2019 06:39
nikitamarysolomanpvt
nikitamarysolomanpvt suggested changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small

PTAL keyboard is appearing and scrolling to bottom

@rt4914
Copy link
Contributor

rt4914 commented Nov 25, 2019

small

PTAL keyboard is appearing and scrolling to bottom

For what its worth, I have not encountered this issue, but still @veena14cs take a deeper look into this.

Also, there is a lot of gap between button and keyboard, which will not look good on smaller screens.
Screenshot_1574657447

@rt4914 rt4914 removed their assignment Nov 25, 2019
@veena14cs
Copy link
Contributor Author

small

PTAL keyboard is appearing and scrolling to bottom

I couldn't reproduce this. Please could you reproduce it so that I can fix it.

@veena14cs
Copy link
Contributor Author

small PTAL keyboard is appearing and scrolling to bottom

For what its worth, I have not encountered this issue, but still @veena14cs take a deeper look into this.

Also, there is a lot of gap between button and keyboard, which will not look good on smaller screens.
Screenshot_1574657447

I have reduced bottom padding please check.

rt4914
rt4914 approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Nov 25, 2019
nikitamarysolomanpvt
nikitamarysolomanpvt approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue i mentioned was occurring only on emulator API 25 and in Fraction Topic.

@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Nov 26, 2019
@veena14cs veena14cs merged commit 10c82fc into develop Nov 27, 2019
@veena14cs veena14cs deleted the submit-button-fix branch November 27, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@nikitamarysolomanpvt nikitamarysolomanpvt nikitamarysolomanpvt approved these changes

Assignees

@veena14cs veena14cs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veena14cs @rt4914 @nikitamarysolomanpvt