Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4524: User icon is seen while opening add profile page for the second time #4670

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

pratyaksh1610
Copy link
Contributor

Explanation

Fix #4524
The user icon is seen clearly while opening the add profile page for the second time.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).
20221022174316.mp4

@BenHenning
Copy link
Member

Thanks @pratyaksh1610. Could you update your PR description to include:

  • An explanation of why the issue was happening (the technical cause)
  • An explanation of the solution & why it works
  • A 'before' video to show the issue to contrast with the 'to video'

Also, please add a test to ensure this continues to work over time and doesn't regress.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 merged commit 47eadaa into oppia:develop Oct 25, 2022
@pratyaksh1610 pratyaksh1610 deleted the icon-branch branch October 25, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User icon is not seen for image while opening add profile page for the second time
3 participants