Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4469: Create a gating parameter for configuration change #4660

Conversation

vrajdesai78
Copy link
Contributor

Explanation

Fixes #4469: Created a platform parameter to enable configuration change. This platform parameter will be used in future PRs related to configuration change. To make data persistent on configuration change, it will required multiple PRs. This platform parameter will be set to false (by default) in production until all PRs related configuration change is merged.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vrajdesai78. Had some suggestions, but otherwise the approach looks correctly.

Please send back once comments are addressed & CI is passing.

@BenHenning BenHenning assigned vrajdesai78 and unassigned BenHenning Oct 18, 2022
@vrajdesai78
Copy link
Contributor Author

Thanks @vrajdesai78. Had some suggestions, but otherwise the approach looks correctly.

Please send back once comments are addressed & CI is passing.

@BenHenning I have replied to all your comments and previously CI checks were failing due to some flaky tests, I hope it will pass this time.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vrajdesai78. I think you might not have fully addressed one of the comments.

Other than that, the PR looks good. The failing CI check does indeed look like a network flake, so I've re-run it (I expect it to pass this time).

@BenHenning BenHenning removed their assignment Oct 18, 2022
@vrajdesai78
Copy link
Contributor Author

Thanks @vrajdesai78. I think you might not have fully addressed one of the comments.

Other than that, the PR looks good. The failing CI check does indeed look like a network flake, so I've re-run it (I expect it to pass this time).

Hey, @BenHenning I have already addressed that comment, can you please look at the changed files again. Thanks

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 removed their assignment Oct 18, 2022
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vrajdesai78. This LGTM!

@BenHenning BenHenning merged commit 2087258 into oppia:develop Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a gating parameter for configuration change
3 participants