-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4469: Create a gating parameter for configuration change #4660
Fixes #4469: Create a gating parameter for configuration change #4660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vrajdesai78. Had some suggestions, but otherwise the approach looks correctly.
Please send back once comments are addressed & CI is passing.
domain/src/main/java/org/oppia/android/domain/platformparameter/PlatformParameterModule.kt
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt
Outdated
Show resolved
Hide resolved
@BenHenning I have replied to all your comments and previously CI checks were failing due to some flaky tests, I hope it will pass this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vrajdesai78. I think you might not have fully addressed one of the comments.
Other than that, the PR looks good. The failing CI check does indeed look like a network flake, so I've re-run it (I expect it to pass this time).
domain/src/main/java/org/oppia/android/domain/platformparameter/PlatformParameterModule.kt
Outdated
Show resolved
Hide resolved
Hey, @BenHenning I have already addressed that comment, can you please look at the changed files again. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vrajdesai78. This LGTM!
Explanation
Fixes #4469: Created a platform parameter to enable configuration change. This platform parameter will be used in future PRs related to configuration change. To make data persistent on configuration change, it will required multiple PRs. This platform parameter will be set to false (by default) in production until all PRs related configuration change is merged.
Essential Checklist