Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4193: Added dark mode support to ProfileProgressActivity, RecentlyPlayedActivity, CompletedStoryListActivity and OngoingTopicListActivity #4612

Merged

Conversation

bhaktideshmukh
Copy link
Contributor

@bhaktideshmukh bhaktideshmukh commented Sep 22, 2022

Explanation

Fixes #4193: This PR adds dark mode support to ProfileProgressActivity, RecentlyPlayedActivity, CompletedStoryListActivity and OngoingTopicListActivity.

Mocks links:--

Screenshots

Default Dark mode
Default Dark mode
Default Dark mode
Default Dark mode

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914
Copy link
Contributor

rt4914 commented Sep 27, 2022

@bhaktideshmukh Merge with latest develop. and after that you can merge this PR. I have approved it.

@rt4914 rt4914 assigned bhaktideshmukh and unassigned rt4914 Sep 27, 2022
@oppiabot oppiabot bot added the PR: LGTM label Sep 27, 2022
@seanlip seanlip assigned BenHenning and unassigned rt4914 Sep 30, 2022
@BenHenning
Copy link
Member

@bhaktideshmukh I think conflicts need to be resolved--PTAL and then assign back once that's done & CI is passing.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bhaktideshmukh. I took a quick pass since @rt4914 already approved the PR, and I didn't see anything problematic.

@BenHenning BenHenning merged commit 49babed into oppia:develop Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants