-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4193: Added dark mode support to ProfileProgressActivity, RecentlyPlayedActivity, CompletedStoryListActivity and OngoingTopicListActivity #4612
Conversation
…d completed_stories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks.
@bhaktideshmukh Merge with latest develop. and after that you can merge this PR. I have approved it. |
@bhaktideshmukh I think conflicts need to be resolved--PTAL and then assign back once that's done & CI is passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bhaktideshmukh. I took a quick pass since @rt4914 already approved the PR, and I didn't see anything problematic.
Explanation
Fixes #4193: This PR adds dark mode support to ProfileProgressActivity, RecentlyPlayedActivity, CompletedStoryListActivity and OngoingTopicListActivity.
Mocks links:--
ProfileProgressActivity: https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/abe3a8a6-0683-43b3-8718-d61edd9682a4/specs/
RecentlyPlayedActivity: https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/2b6c8e95-5ac7-4472-bc2b-1c318a3f7e5c/specs/
CompletedStoryListActivity: https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/f54ae7d1-9530-44d6-8783-21559b13635c/specs/
OngoingTopicListActivity: https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/a80d1be8-d4b4-4fee-a46d-296b5aa6a110/specs/
Screenshots
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: