Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4322: Stops Talkback from pronouncing asterisks. #4601

Merged
merged 39 commits into from
Nov 1, 2022

Conversation

Ryggs
Copy link
Contributor

@Ryggs Ryggs commented Sep 19, 2022

Explanation

Fixes #4322

This PR stops talkback from pronouncing the word asterisks and instead pronounces the word required.

It introduces the usage of the helperText attribute and the removal of all occurrences of the *, in string files. The fields affected in the add profile activity layout file are name, pin, and confirm pin.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Demo

ORIGINAL WITHOUT TALKBACK

dev-no-talkback.mp4

ORIGINAL WITH TALKBACK

dev-with-talkback.webm

FIXED PR ISSUE WITHOUT TALKBACK

after-change-non-talkback.mp4

FIXED PR ISSUE WITH TALKBACK

after-change-talkback.mp4

Tests

h1pass

@Ryggs Ryggs marked this pull request as ready for review September 20, 2022 13:07
@Ryggs Ryggs requested a review from rt4914 as a code owner September 21, 2022 15:39
@Ryggs
Copy link
Contributor Author

Ryggs commented Sep 21, 2022

@BenHenning, this duplicate causes breaks. But its present in the origin/develop. As seen here https://github.com/oppia/oppia-android/blob/develop/app/src/main/res/values/color_defs.xml

Build Error Image:
dup

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ryggs. I took at the PR and left one follow-up comment.

Regarding the failure, it should go away if you sync to the latest develop. The PR that caused it has been reverted.

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@BenHenning BenHenning assigned Ryggs and unassigned BenHenning Sep 21, 2022
@BenHenning
Copy link
Member

Sending this back to you @Ryggs per the comment above, and also converting it to be a draft PR since it's still a work-in-progress.

@BenHenning BenHenning marked this pull request as draft October 4, 2022 06:45
@BenHenning BenHenning removed their assignment Oct 4, 2022
@Ryggs Ryggs marked this pull request as ready for review October 5, 2022 23:40
@Ryggs Ryggs assigned BenHenning and unassigned Ryggs Oct 22, 2022
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ryggs. Left a few follow-up comments, but this seems close to done. PTAL.

@BenHenning BenHenning assigned Ryggs and unassigned BenHenning Oct 25, 2022
@Ryggs Ryggs assigned BenHenning and unassigned Ryggs Oct 25, 2022
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ryggs. Just a couple of follow-ups--PTAL.

app/src/main/res/layout/add_profile_activity.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@BenHenning BenHenning assigned rt4914 and Ryggs and unassigned BenHenning Oct 26, 2022
@BenHenning
Copy link
Member

Assigning @rt4914 since I think he can take a look at this now.

@rt4914
Copy link
Contributor

rt4914 commented Oct 28, 2022

I will review it today.

@Ryggs Ryggs requested a review from BenHenning October 29, 2022 07:06
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Ryggs Thanks.

@oppiabot oppiabot bot unassigned rt4914 Oct 31, 2022
@oppiabot
Copy link

oppiabot bot commented Oct 31, 2022

Unassigning @rt4914 since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Oct 31, 2022

Assigning @BenHenning for code owner reviews. Thanks!

@Ryggs Ryggs removed their assignment Oct 31, 2022
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ryggs. This LGTM!

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Talkback is reading astreisk for required fields
6 participants