Fix #4581: Privacy policy hyperlink in Terms of Service #4595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sFragmentTest.kt Co-authored-by: Ben Henning <[email protected]>
Thanks. I have fixed the issue. PTAL. |
BenHenning
reviewed
Oct 25, 2022
There was a problem hiding this comment.
Thanks @veena14cs! Just a few nits left, otherwise this LGTM.
app/src/sharedTest/java/org/oppia/android/app/policies/PoliciesActivityTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/policies/PoliciesActivityTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/policies/PoliciesActivityTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/policies/PoliciesFragmentTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/policies/PoliciesFragmentTest.kt
Outdated
Show resolved
Hide resolved
…sActivityTest.kt Co-authored-by: Ben Henning <[email protected]>
Thanks @BenHenning I have fixed nits. PTAL. |
BenHenning
approved these changes
Oct 26, 2022
|
Unassigning @BenHenning since they have already approved the PR. |
|
Hi @veena14cs, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #4581 . This PR fixes the privacy policy hyperlink in Terms of service page.
Before and after video
before.mp4
after.mp4
Essential Checklist