Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #432: Radio button fixed #459

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Fix #432: Radio button fixed #459

merged 1 commit into from
Nov 20, 2019

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 20, 2019

Explanation

This PR is actually a quite weird fix for radio buttons.

  1. As soon as the SelectionInteractionView is used, the default value for selectionItemInputType is CheckBoxes, which was getting updated later on in code but was not getting reflected in UI.
  2. In SelectionInteractionView, even though the information that we have to show RadioButton is getting transferred correctly but adapter!!.notifyDataSetChanged() is not updating the UI.
  3. In selection_interaction_item.xml changing the order of data binding and bringing itemInputType to top in SelectionInteractionView worked which made me wondering that do we need to follow order of xml attributes while writing them in XML file?
  4. Because when we press Option+cmd+L which will reorganise the XML file in alphabetical order and again the same issue will arise, I changed the name of itemInputType to allOptionstemInputType, so that it remains on top even in case of reorganising.

Screenshot_1574275914

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@BenHenning
Copy link
Member

Ah. This binding was a race condition, so I'm wondering if a recent change altered the timing of something to trigger this.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think this is a reasonable fix either way, let's take it.

@BenHenning BenHenning merged commit fdccc6f into develop Nov 20, 2019
@BenHenning BenHenning deleted the radio-button-fix branch November 20, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants