Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #295: Move passing tests of the app module to the non_flaky_tests workflow #457

Merged
merged 18 commits into from
Nov 27, 2019

Conversation

vinitamurthi
Copy link
Contributor

@vinitamurthi vinitamurthi commented Nov 20, 2019

Explanation

Run the app tests on robolectric in circle ci and move the passing tests into the non_flaky queue. Also fixes dagger issues in AudioFragmentTest and HtmlParserTest
Fixes part of #295

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@vinitamurthi vinitamurthi changed the title [TEST][DO NOT MERGE] Test adding an emulator to circleci Fix part of #295: Move passing tests of the app module to the non_flaky_tests workflow Nov 20, 2019
@vinitamurthi
Copy link
Contributor Author

@jamesxu0 @BenHenning PTAL

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And thanks for fixing the existing breakages.

Copy link
Contributor

@jamesxu0 jamesxu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesxu0 jamesxu0 removed their assignment Nov 25, 2019
@vinitamurthi vinitamurthi merged commit d19815d into develop Nov 27, 2019
@vinitamurthi vinitamurthi deleted the circleci_app branch November 27, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants