Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #441: Remove \n\t and \n\n #454

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Fix #441: Remove \n\t and \n\n #454

merged 1 commit into from
Nov 20, 2019

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 20, 2019

Explanation

This PR removes extra empty space from exploration.

Before

Screenshot_1574270917

After

Screenshot_1574270483

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914. We should add tests for these cases in a follow up PR.

This looks much better. I think we also need to figure out how to improve the styling for some of the elements though. The bullets are too small and the spacing seems a bit off.

@BenHenning BenHenning merged commit 4fc25be into develop Nov 20, 2019
@BenHenning BenHenning deleted the bullet-html-parsing branch November 20, 2019 17:32
@rt4914
Copy link
Contributor Author

rt4914 commented Nov 20, 2019

Thanks @rt4914. We should add tests for these cases in a follow up PR.

This looks much better. I think we also need to figure out how to improve the styling for some of the elements though. The bullets are too small and the spacing seems a bit off.

Filed two new issues for tests and bullet improvisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants