Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4447: Hide Info tab #4528

Merged
merged 59 commits into from
Sep 27, 2022
Merged

Fix #4447: Hide Info tab #4528

merged 59 commits into from
Sep 27, 2022

Conversation

JishnuGoyal
Copy link
Contributor

@JishnuGoyal JishnuGoyal commented Aug 24, 2022 •
edited
Loading

Explanation

Fixes #4447

This PR hides the info tab in the Topic screen, as part of the Interactive Onboarding Flow project (GSoC), thus fixing #4447. It does so by introducing a new platform parameter enableExtraTopicTabsUi which hides info and practice tab as well. The practice tab's visibility was earlier controller by a flag called enablePracticeTab which used some legacy code and was removed in this PR. Thus, lessons tab is the default tab upon landing on the topic screen.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Before:
image

image

After:
image

image

@JishnuGoyal
Copy link
Contributor Author

JishnuGoyal commented Aug 24, 2022 •
edited
Loading

Please take an initial pass at this -- please let me know if more test cases are needed.

BenHenning
BenHenning requested changes Aug 25, 2022
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JishnuGoyal! I took a first pass, but skipped the main tests until the next pass. I think there's some additional adjustments needed here per my comments and suggestions.

Beyond that, could you please also fill in the explanation section for the PR? There's important context to capture here both in terms of what new behavior you're adding (hiding the info tab + why), and what behavior you're changing (also gating the practice tab behind the same flag + why).

...src/main/java/org/oppia/android/app/application/alphakenya/AlphaKenyaApplicationComponent.kt Outdated Show resolved Hide resolved
...src/main/java/org/oppia/android/app/application/alphakenya/AlphaKenyaApplicationComponent.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/topic/TopicFragmentPresenter.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/android/app/topic/TopicTab.kt Outdated Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt Outdated Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt Show resolved Hide resolved
@BenHenning BenHenning assigned JishnuGoyal and unassigned BenHenning Aug 25, 2022
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 25, 2022
BenHenning
BenHenning reviewed Sep 25, 2022
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JishnuGoyal. Just had a few follow-ups, along with a reminder that there's 1 CI check left to fix. Otherwise, the PR is pretty much LGTM.

app/src/sharedTest/java/org/oppia/android/app/topic/TopicFragmentTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/topic/TopicFragmentTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/topic/lessons/TopicLessonsFragmentTest.kt Outdated Show resolved Hide resolved
@BenHenning
Copy link
Member

@JishnuGoyal please also add screenshots of Espresso tests passing for changed test suites (such as TopicFragmentTest).

@JishnuGoyal
Copy link
Contributor Author

@rt4914 PTAL for codeowners, thanks.

@oppiabot oppiabot bot assigned rt4914 and unassigned JishnuGoyal Sep 26, 2022
@oppiabot
Copy link

oppiabot bot commented Sep 26, 2022

Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks!

@JishnuGoyal
Copy link
Contributor Author

image

Espresso test results on my branch.

image

Espresso tests failing originally on develop (same status as the tests on my branch)

@JishnuGoyal
Copy link
Contributor Author

JishnuGoyal commented Sep 26, 2022 •
edited
Loading

image

Espresso test status on my branch

(the same test currently fails on develop too)

rt4914
rt4914 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @JishnuGoyal . Really nice work.

@rt4914 rt4914 assigned JishnuGoyal and unassigned rt4914 Sep 26, 2022
@JishnuGoyal
Copy link
Contributor Author

Thank you so much, so happy to hear :)

BenHenning
BenHenning reviewed Sep 26, 2022
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JishnuGoyal. Just one minor nit left, otherwise the PR LGTM.

app/src/sharedTest/java/org/oppia/android/app/topic/TopicFragmentTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/topic/TopicFragmentTest.kt Outdated Show resolved Hide resolved
@JishnuGoyal
Copy link
Contributor Author

PTAL @BenHenning , thanks

@oppiabot oppiabot bot assigned BenHenning and unassigned JishnuGoyal Sep 26, 2022
@oppiabot
Copy link

oppiabot bot commented Sep 26, 2022

Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks!

BenHenning
BenHenning approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM--thanks @JishnuGoyal!

@BenHenning BenHenning merged commit c9c4d9a into oppia:develop Sep 27, 2022
@JishnuGoyal JishnuGoyal deleted the 1.3_hide_topic_tabs branch December 27, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@BenHenning BenHenning BenHenning approved these changes

Assignees

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide Info tab
3 participants
@JishnuGoyal @BenHenning @rt4914