Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #445: multiple choice state focus issue #448

Merged
merged 5 commits into from
Nov 20, 2019
Merged

Fix #445: multiple choice state focus issue #448

merged 5 commits into from
Nov 20, 2019

Conversation

nikitamarysolomanpvt
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt commented Nov 20, 2019 •
edited
Loading

Explanation

Opening exploration with initial multiple choice state focuses on interaction is fixed.(If in any scenario this issue is produced please suggest the issue with scenario)

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

rt4914
rt4914 approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, haven't encountered any issue in exploration yet.

veena14cs
veena14cs approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikitamarysolomanpvt
nit
bc4d3d5
@nikitamarysolomanpvt
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
a666723 
… topic-multiple-choice-focus-issue-fix

# Conflicts:
#	app/src/main/res/layout/selection_interaction_item.xml
veena14cs
veena14cs approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikitamarysolomanpvt nikitamarysolomanpvt merged commit 29d7441 into develop Nov 20, 2019
@nikitamarysolomanpvt nikitamarysolomanpvt deleted the topic-multiple-choice-focus-issue-fix branch November 20, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@veena14cs veena14cs veena14cs approved these changes

Assignees

@BenHenning BenHenning

@nikitamarysolomanpvt nikitamarysolomanpvt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikitamarysolomanpvt @rt4914 @veena14cs @BenHenning