-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #430 : Reduce white space between feedback & answer & content boxes #447
Conversation
@veena14cs One question -- in the second screenshot, can you reduce the vertical whitespace at the top and the bottom of the item selection input? There's quite a lot of it. Sorry I missed this earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veena14cs LGTM, but it might get updated a little bit when we finish Hifi for exploration/state fragment. For now this should get merged.
Thanks. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. If it passes accessibility tests (please verify) then LGTM from a UI perspective.
Yes it does. Thanks. |
Since this is a checkbox question, can we add a description above the choices that reads "Please select at least one choice" like in this mock? Also when the user submits the right answers, only their answers are shown, so any answers that were unselected should disappear as well. These are the only functional improvements I would make to this, but otherwise the formatting looks great! |
Explanation
This PR fixes white spaces between Feedback, answer and content boxes.
Note :
Lerners's response
box width based on its content is being fixed in #412 . This PR focuses only on spacing.Mock
https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/5954b83a-4bcf-4fa6-8382-f814137fa8ab/PM-Q4-Fill-In-Learn-Again-/
Accessibility Scanner
Screenshot