-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4443: Talkback reader reads blank on empty resume lesson summary #4444
Fixes #4443: Talkback reader reads blank on empty resume lesson summary #4444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrajdesai78 PTAL. Thanks.
app/src/main/java/org/oppia/android/app/resumelesson/ResumeLessonFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
Hi @vrajdesai78, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Keep this PR open |
When I tried to write test case https://gist.github.com/vrajdesai78/5088cd112ecf3c505ff13b79ac433bd1 it's showing me error as shown below. I have tried to create newTestChecking test to test whether textView is set to ImportantForAccessibility or Not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrajdesai78 PTAL.
app/src/main/java/org/oppia/android/app/resumelesson/ResumeLessonFragmentPresenter.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks.
Explanation
Fixes #4443: Handles edge case where the summary for resume lesson is empty.
Essential Checklist
Before
blank-space.mp4
After
accessibility-blank.mp4
Passing Test cases