Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4443: Talkback reader reads blank on empty resume lesson summary #4444

Merged

Conversation

vrajdesai78
Copy link
Contributor

@vrajdesai78 vrajdesai78 commented Jul 22, 2022

Explanation

Fixes #4443: Handles edge case where the summary for resume lesson is empty.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Before

blank-space.mp4

After

accessibility-blank.mp4

Passing Test cases

Screenshot from 2022-08-03 11-11-23
Screenshot from 2022-08-03 11-12-05

@vrajdesai78 vrajdesai78 requested a review from rt4914 as a code owner July 22, 2022 07:32
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrajdesai78 PTAL. Thanks.

@rt4914 rt4914 assigned vrajdesai78 and unassigned rt4914 Jul 22, 2022
@oppiabot
Copy link

oppiabot bot commented Jul 29, 2022

Hi @vrajdesai78, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 29, 2022
@vrajdesai78
Copy link
Contributor Author

Keep this PR open

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 30, 2022
@vrajdesai78
Copy link
Contributor Author

When I tried to write test case https://gist.github.com/vrajdesai78/5088cd112ecf3c505ff13b79ac433bd1 it's showing me error as shown below. I have tried to create newTestChecking test to test whether textView is set to ImportantForAccessibility or Not.

Screenshot from 2022-07-30 00-25-40

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrajdesai78 PTAL.

@rt4914 rt4914 removed their assignment Aug 2, 2022
@vrajdesai78 vrajdesai78 assigned rt4914 and unassigned vrajdesai78 Aug 3, 2022
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 merged commit d8ab9e9 into oppia:develop Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Talkback reader reads blank on empty resume lesson summary
2 participants