-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3473 #3545 #3588 : Merge faq_list_fragment, ongoing_topic_item and topic_revision_summary_view #4365
Conversation
Thanks for submitting this pull request! Some main reviewers |
android:layout_marginTop="4dp" | ||
android:layout_marginEnd="8dp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These margins are not required anymore because correct constraints have been added at bottom.
Hi @rt4914, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's look good to me.
It able to merge.
Merging per @rt4914's request. |
Explanation
Fix #3473 : Merge
faq_list_fragment
- In this only the un-required attributes were removed, otherwise the code is already optimised.Fix #3545 : Merge
ongoing_topic_item
Fix #3588 : Merge
topic_revision_summary_view
Essential Checklist
Before and After Screenshots