Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3473 #3545 #3588 : Merge faq_list_fragment, ongoing_topic_item and topic_revision_summary_view #4365

Merged
merged 4 commits into from
May 25, 2022

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 17, 2022

Explanation

Fix #3473 : Merge faq_list_fragment - In this only the un-required attributes were removed, otherwise the code is already optimised.
Fix #3545 : Merge ongoing_topic_item
Fix #3588 : Merge topic_revision_summary_view

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Before and After Screenshots

@github-actions
Copy link

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 23 May 2022.

android:layout_marginTop="4dp"
android:layout_marginEnd="8dp"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These margins are not required anymore because correct constraints have been added at bottom.

@oppiabot
Copy link

oppiabot bot commented May 24, 2022

Hi @rt4914, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label May 24, 2022
Copy link
Member

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's look good to me.
It able to merge.

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label May 25, 2022
@rt4914 rt4914 requested a review from seanlip May 25, 2022 05:47
@seanlip
Copy link
Member

seanlip commented May 25, 2022

Merging per @rt4914's request.

@seanlip seanlip merged commit 9462690 into develop May 25, 2022
@seanlip seanlip deleted the merge-xml-files-part-2 branch May 25, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants